SEZ9 commented on PR #13238:
URL: https://github.com/apache/seatunnel/pull/13238#issuecomment-6843200409

   Thanks @SEPURI-SAI-KRISHNA for the careful read and for trying the 
second-rule scenario on dev — that makes the first point very concrete. And 
thanks @nzw921rx for the review.
   
   On point 1: agreed that the `catch (OptionValidationException e)` in 
`FactoryUtil.createMultiTableSink` is accurate today only because the rule has 
a single option. Of the two options you list, I'd lean toward the first for 
this PR: append the replica/value part only when the configured replica is 
actually below 1, and otherwise keep the generic message. Putting the 
configured value into the generic value-constraint error in `ConfigValidator` 
is the better long-term fix for the #11007 direction, but as you note it needs 
care for sensitive options such as passwords, so I'd rather keep it as a 
follow-up than widen the scope here.
   
   On point 2: agreed as well. The 256-value random sample in 
`testReplicaOptionRuleMatchesPositiveIntegerRange` doesn't add coverage beyond 
the fixed boundaries already there, and the fixed values alone are 
deterministic, which is what AGENTS.md asks for.
   
   Since neither point is blocking, I'm fine with either addressing both in a 
small follow-up push to this PR or handling them separately — whichever the 
author prefers. Approval above is conditional on CI passing, so once the fork 
CI run for the head commit finishes we should be good to go.
   
   <!-- streview-comment:2316 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to