zhangshenghang commented on issue #13226: URL: https://github.com/apache/seatunnel/issues/13226#issuecomment-6812125765
Update after review: the implementation passes the **entire** `env` block, not only `custom_parameters`. - `TableFactoryContext#getEnvOptions()` returns the full `ReadonlyConfig` parsed from `env`, so source, transform, sink, multi-sink and restore-source factories can read any top-level key (for example `env.my_key`). - `custom_parameters` remains an optional namespace for grouping, but is no longer the only accepted location. - `--check` now treats `env` as an open map: it still validates required options and the types of declared env options, but no longer rejects unknown top-level keys, so user-defined variables are not misreported as typos. - Stage 1 tests (API + Zeta parser) now use a plain top-level `probe` key instead of `custom_parameters` to prove the whole block is forwarded. - `env` is still not a secret store: `ConfigShadeUtils` only handles `source`/`sink`/`transform`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
