SEZ9 commented on issue #13226: URL: https://github.com/apache/seatunnel/issues/13226#issuecomment-6819189494
Thanks for the staged split and the compatibility table — that addresses the review points, and agreed on keeping `env` out of the credential path. One question on the latest update: with `--check` now treating `env` as an open map, a misspelled engine-level key (for example a typo in `parallelism` or a checkpoint option) would no longer be reported and would silently fall back to defaults. Could you describe how the `--check` change distinguishes declared env options from user-defined keys, and make sure the EN/ZH docs state clearly that unknown top-level `env` keys are accepted and forwarded via `TableFactoryContext#getEnvOptions()` rather than validated, and that `env` is not decrypted by `ConfigShadeUtils`? Agreed on keeping the UDF integration for the stage 2 PR once the stage 1 factory API contract is settled. <!-- streview-comment:2298 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
