SEZ9 commented on issue #13263:
URL: https://github.com/apache/seatunnel/issues/13263#issuecomment-6871069761

   Thanks for the detailed report and the CI links. I agree that the default 
port wait is not a sufficient readiness signal here, and since `tidb.toml` only 
logs errors, the CI log cannot distinguish the two cases you describe.
   
   Your proposed fix sounds right: waiting in `TiDBTestBase.startContainers()` 
until `SELECT 1` succeeds (retrying every second for up to 120 seconds) and 
logging each failed attempt covers both the not-yet-listening case and the 
connection-closed-before-greeting case, and the logging will make future 
failures easier to diagnose. Keeping the change limited to `TiDBTestBase` is a 
good idea.
   
   Please go ahead and open the PR once it has passed in CI; re-running 
`updated-modules-integration-test-part-6` a few times would help confirm the 
flakiness is gone. Feel free to link it back to this issue.
   
   <!-- streview-comment:2343 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to