SEZ9 commented on issue #13263: URL: https://github.com/apache/seatunnel/issues/13263#issuecomment-6888077283
Thanks @SEPURI-SAI-KRISHNA, that approach matches the root cause here: the default port wait only tells us the port is open, not that TiDB is actually accepting and serving connections, so polling `SELECT 1` in `TiDBTestBase.startContainers()` is the right place to close the gap. A few asks for when you open the PR: - Please link it back to this issue and briefly describe in the PR body the "two cases" you mentioned, so reviewers can tie each log message to a failure mode. - Keep the retry interval and the 120-second cap as named constants rather than inline literals, so they are easy to tune if CI turns out to need more headroom. - Make sure the per-attempt log line includes the underlying exception message, since that is what will tell us in a CI log whether the connection was refused or TiDB answered but was not ready. - Once it is green in CI, it would be helpful to run `TiDBCDCIT` a few times in a row (locally is fine) and note the results in the PR, given this was intermittent. Good to hear the 4 Zeta tests already pass locally. Ping me on the PR when it is up and I will review. <!-- streview-comment:2356 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
