erica1111-prog commented on issue #11007:
URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6873436125

   > [@erica1111-prog](https://github.com/erica1111-prog) — thanks for the 
follow-up, and for pinning the base commit to 
`c875a87bd6fb238585dd6856c2c4233b6a8ece46`; that's trackable now.
   > 
   > On the mutual-exclusion rule: the restated grouping is clear — Group A is 
`KEY_MEASUREMENT_RULE` bundled with optional `KEY_MEASUREMENT_FIELD`, Group B 
is standalone `MEASUREMENT`, and a sink config can't supply both. That's what 
we'd expect `optionRule()` to encode for the `connector-influxdb` sink slice.
   > 
   > Two things are still open before this slice can be confirmed here:
   > 
   > 1. Your point 3 on blank / padded values is cut off again at 
"blank/whitespace-only/padded string va". From the lead-in it sounds like you 
intend to keep those out of this slice to avoid touching runtime URL/database 
parsing — that's fine, but please repost the end of that sentence so the 
decision is explicit on record.
   > 2. Points 4 (EN/ZH required/optional markers matching what `optionRule()` 
enforces) and 5 (the earlier note truncated at "zero runti") didn't make it 
into the reply. Please add a one-line confirmation for the docs check and the 
missing tail of the earlier note.
   > 
   > Once those are posted, the `connector-influxdb` sink slice (limited to 
`InfluxDBSinkFactory` and `InfluxDBFactoryTest`, as you described) can be 
confirmed here. No assignment change yet.
   > 
   > [@Meganexxx](https://github.com/Meganexxx) — noted that connector-assert 
is being handled in [#13095](https://github.com/apache/seatunnel/pull/13095); 
no action needed here.
   
   @SEZ9 Apologies for the copy-paste truncation! Here are the remaining 
confirmations on record:
   
   1. **Blank / Padded Values**: Deliberately kept out of this slice so we do 
not touch runtime URL/database parsing; tests cover valid configs, missing 
required options (`URL`, `DATABASES`), and mutual exclusion (`MEASUREMENT` vs 
`KEY_MEASUREMENT_RULE`).
   2. **Docs Contract**: Confirmed that `docs/en/connector-v2/sink/InfluxDB.md` 
and `docs/zh/connector-v2/sink/InfluxDB.md` already match the required/optional 
markers enforced by `optionRule()`, so no doc updates are needed.
   3. **Scope Boundary**: All changes are strictly isolated to 
`InfluxDBSinkFactory` and `InfluxDBFactoryTest` with zero runtime changes to 
the InfluxDB sink execution logic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to