SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-6961544619
@erica1111-prog — thanks, noted that the PR is up at #13049. Your previous comment closed the items that were still open here: - **Blank / padded values**: deliberately kept out of this slice so runtime URL/database parsing is not touched. Tests cover valid configs, missing required options (`URL`, `DATABASES`), and mutual exclusion (`MEASUREMENT` vs `KEY_MEASUREMENT_RULE`). - **Docs**: you confirmed the EN/ZH InfluxDB sink docs already match the required/optional markers enforced by `optionRule()`, so no doc updates are needed. - **Scope boundary**: changes are limited to `InfluxDBSinkFactory` and `InfluxDBFactoryTest`, with zero runtime changes to the sink execution logic. That was everything requested for the `connector-influxdb` sink slice, so nothing further is needed from you on this thread for those points. I have not reviewed #13049 yet; that will happen on the PR itself. Two small asks for the PR: 1. Please copy the base commit `c875a87bd6fb238585dd6856c2c4233b6a8ece46` and the blank/padded-values exclusion into the PR description, so reviewers there have the same record. 2. Please keep the diff to what was agreed here: Group A (`KEY_MEASUREMENT_RULE` bundled with optional `KEY_MEASUREMENT_FIELD`) exclusive with Group B (standalone `MEASUREMENT`), and only the two files named above. <!-- streview-comment:2406 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
