Dev-next-gen commented on PR #12269:
URL: https://github.com/apache/seatunnel/pull/12269#issuecomment-6890004515

   @SEZ9 the two starter converters were a real gap, thanks for tracing them 
through to the misleading "only support these options" message. I pushed 
b76ec3a51 on top of the sync: `ConnectorCheckCommandArgs` and 
`MetadataExportCommandArgs` now use `toUpperCase(Locale.ROOT)`, the five 
`toLowerCase()` calls in `getPluginMappingPrefix`/`findPluginJarPath` pass 
`Locale.ROOT`, and the Turkish-locale discovery test also resolves the `Jdbc` 
sink, so the `PluginType` from the fixed line now goes through 
`selectPluginJar`/`findMatchingUrl`. I added 
`testSinkPluginTypeUnderTurkishLocale` to `ConnectorCheckCommandArgsTest`, 
which parses `-pt sink` under tr-TR and also calls 
`MetadataExportCommandArgs.PluginTypeConverter` directly.
   
   I ran both test classes on JDK 17 with the new tests, first against the 
`dev` versions of the three main files, then with the change:
   
   ```
   # main sources from dev
   getSinkPluginJarPathsUnderTurkishLocale  <<< ERROR!
   java.lang.IllegalArgumentException: No enum constant 
org.apache.seatunnel.common.constants.PluginType.SİNK
   testSinkPluginTypeUnderTurkishLocale  <<< ERROR!
   java.lang.IllegalArgumentException: The plugin type of seaTunnel only 
support these options: [source, transform, sink]
   
   # with b76ec3a51
   Tests run: 6, Failures: 0, Errors: 0, Skipped: 0 - in 
...SeaTunnelSourcePluginDiscoveryTest
   Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 - in 
...ConnectorCheckCommandArgsTest
   ```
   
   `spotless:check` passes on both modules.
   
   Found by a defect-hunting pipeline I build and run 
([Dev-next-gen](https://github.com/Dev-next-gen)), using Claude Code with 
Anthropic's Claude Opus 5.5.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to