Dev-next-gen commented on PR #12269:
URL: https://github.com/apache/seatunnel/pull/12269#issuecomment-6991939056

   @SEZ9 @DanielLeens the branch had picked up a conflict with `dev`: #13081 
(merged today) made the same `toUpperCase(Locale.ROOT)` change to 
`ConnectorCheckCommandArgs` and `MetadataExportCommandArgs`, with its own 
Turkish-locale test in `ConnectorCheckCommandArgsTest`. I merged `dev` in 
8a49d71e4 (a merge commit, no rewrite) and took the `dev` version of that test, 
since it covers the same `-pt sink` case. The two starter main files were 
already identical to `dev`, so the PR diff is now 
`AbstractPluginDiscovery.java` and `SeaTunnelSourcePluginDiscoveryTest.java` 
only, and GitHub reports it as mergeable again.
   
   On the merged tree, JDK 17: `spotless:check` passes on both modules, 
`SeaTunnelSourcePluginDiscoveryTest` runs 6 tests and 
`ConnectorCheckCommandArgsTest` 2, with 0 failures and 0 errors. With 
`AbstractPluginDiscovery.java` reverted to `dev`, 
`getSinkPluginJarPathsUnderTurkishLocale` still fails with `No enum constant 
org.apache.seatunnel.common.constants.PluginType.SİNK`.
   
   Found by a defect-hunting pipeline I build and run 
([Dev-next-gen](https://github.com/Dev-next-gen)), using Claude Code with 
Anthropic's Claude Opus 5.5.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to