SEZ9 commented on PR #12156:
URL: https://github.com/apache/seatunnel/pull/12156#issuecomment-6937170737

   Thanks @CryoThrust. Syncing `dev` (`eccda139e`) to pick up the existing SFTP 
fixture fix, with no connector or dependency workaround, was the right way to 
handle it.
   
   The Paimon IT / JDK 17 failure you describe (HTTP 429 on all five Maven 
Wrapper downloads before any Paimon test ran) is unrelated to this change, so 
retrying only that job on the unchanged head is fine.
   
   You report the [Build on 
`9293d31d1`](https://github.com/CryoThrust/seatunnel/actions/runs/43866946838) 
as successful, with 86 successful jobs, 11 conditionally skipped, and both SFTP 
lanes and both engine integration lanes passing. On that basis, the failing 
Build that was holding this up is no longer in the way.
   
   My earlier source-level conclusion is unchanged. I've noted your update that 
the cancellation fixture now closes its cached executor after each test, that 
production cleared-state behavior is unchanged, and that the separate 
check-then-act follow-up stays as it is. I have no further requests from my 
side.
   
   <!-- streview-comment:2399 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to