Rangsh commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-7055023277
@SEZ9 @DanielLeens Thanks for the follow-up on `5f829fde`. **Your two open confirmation items (Nov 18)** — I agree with @DanielLeens's Nov 19 source read and am confirming from the author side: 1. **Untimed `RequestFuture.get()`** — Production callers in `IMapFileStorage` use only the timed overload (`queryExecuteStatusBeforeDeadline` / `batchQueryExecuteFailsStatus`). The untimed overload stays for the `Future` API but delegates to the configured timeout; no production path relies on the old 1s-capped behavior. 2. **Mockito test classpath** — `mockito-junit-jupiter` (and `mockito-inline`) comes from the root POM test dependencies (`pom.xml` ~726–736). The duplicate entry was removed from `imap-storage-file/pom.xml` in `43e18b1e6`. **Daniel review (Nov 18) — code now on `68b9975dec`:** - **Issue 1 (ring admission):** One operation deadline covers ring admission and the subsequent future wait. `WALDisruptor` uses non-blocking `tryPublishEvent` with a bounded spin/wait budget; rejected admissions drop the pending future and fail the write-through path. Docs updated in `incompatible-changes.md` (en/zh). Tests: `WALDisruptorBoundedAdmissionTest`, `IMapFileStorageRingAdmissionTest`; batch deadline test updated for the shared deadline parameter. - **Issue 2 (engine recovery boundary):** `CheckpointManagerTest.testPayloadAndMonitorFailuresStayIsolatedAcrossRestore` — monitor cleanup failure does not delete the durable checkpoint payload; payload delete failure does not invoke monitor cleanup. - **Non-blocking:** `FileMapStoreTest` replay Javadoc corrected (fresh node writes a new region; durable prefix still replays). Fork **Build** is running for this SHA (push to `improve/zeta-checkpoint-state-store-latency-12058` plus `build_main.yml` dispatch). I will watch CI and follow up if anything fails. Happy to take another pass once Build is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
