Rangsh commented on PR #12081:
URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-7063275135

   @DanielLeens @SEZ9
   
   Thanks for the Nov 21 review. Pushed `412ee1c763` addressing the five 
blocking items:
   
   1. **Full-ring admission** — `WALDisruptorBoundedAdmissionTest` now stalls 
the sole consumer, saturates a size-4 ring, asserts watchdog rejection and 
future eviction; `IMapFileStorageRingAdmissionTest` covers storage-layer 
overflow with the same pattern.
   2. **Engine FT (payload vs monitor)** — added 
`CheckpointPayloadMonitorFaultToleranceTest`: real streaming job with 
checkpoints, `cleanupJob` write-through failure injected on the live 
`JobMaster`, cancel with retain — durable checkpoint payload remains.
   3. **Interrupt during admission** — `WALDisruptor.tryPublish` honors 
`Thread.interrupted()` around `parkNanos`; saturated-ring + interrupt 
regression included.
   4. **Batch deadline tests** — `IMapFileStorageBatchDeadlineTest` uses public 
`storeAll` / `deleteAll` (no reflection on `batchQueryExecuteFailsStatus`).
   5. **Flush observability** — `HdfsWriterFlushCallCountTest` adds 
local-filesystem write → flush → `WALReader` read-back alongside the existing 
hsync branch call-count tests.
   
   Local checks:
   - `./mvnw spotless:apply -pl :imap-storage-file,:seatunnel-engine-server`
   - `./mvnw -pl :imap-storage-file test 
-Dtest=WALDisruptorBoundedAdmissionTest,IMapFileStorageBatchDeadlineTest,IMapFileStorageRingAdmissionTest,HdfsWriterFlushCallCountTest`
   - `./mvnw -pl :seatunnel-engine-server test 
-Dtest=CheckpointPayloadMonitorFaultToleranceTest`
   
   Fork Build will be re-triggered on this push. Please take another look when 
convenient.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to