yhs0092 commented on a change in pull request #1301: [SCB-1450] Microservice instance may get stuck when watch connection to sc is recovered and pulling instance action is executed in eventloop thread URL: https://github.com/apache/servicecomb-java-chassis/pull/1301#discussion_r317403005
########## File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/AbstractClientPool.java ########## @@ -42,27 +45,41 @@ public static final String PROXY_KEY = "sc.consumer"; + private static final String EVENT_LOOP_POOL_SIZE = "servicecomb.service.registry.client.eventLoopPoolSize"; + + private static final String WORKER_POOL_SIZE = "servicecomb.service.registry.client.workerPoolSize"; Review comment: `servicecomb.service.registry.client.workerPoolSize` is used as the key of another configurations. This is a change not compatible. Could you update the corresponding docs? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
