yhs0092 commented on a change in pull request #1301: [SCB-1450] Microservice
instance may get stuck when watch connection to sc is recovered and pulling
instance action is executed in eventloop thread
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1301#discussion_r317403217
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/config/ServiceRegistryConfig.java
##########
@@ -109,22 +109,23 @@ public HttpVersion getHttpVersion() {
return HttpVersion.valueOf(property.get());
}
- public int getWorkerPoolSize() {
- String workerPoolSizeKey =
"servicecomb.service.registry.client.workerPoolSize";
+ public int getInstances() {
+ String instances = "servicecomb.service.registry.client.instances ";
DynamicIntProperty property =
- DynamicPropertyFactory.getInstance()
- .getIntProperty(workerPoolSizeKey, 1);
- int workerPoolSize = property.get();
- if (workerPoolSize <= 0) {
+ DynamicPropertyFactory.getInstance()
+ .getIntProperty(instances, 1);
+ int deployInstances = property.get();
+ if (deployInstances <= 0) {
int nAvailableProcessors = Runtime.getRuntime().availableProcessors();
LOGGER.warn("The property `{}` must be positive integer, fallback to use
number of available processors: {}",
- workerPoolSizeKey,
- nAvailableProcessors);
+ instances,
+ nAvailableProcessors);
Review comment:
The indent of some files seems not consistent with the other code, like here
and `AbstractClientPool`. Could you reformat your pull request? You can find
the code template
[here](https://github.com/apache/servicecomb-java-chassis/tree/master/etc).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
