popozy commented on a change in pull request #698:
URL:
https://github.com/apache/servicecomb-service-center/pull/698#discussion_r495676301
##########
File path: server/service/ms/datasource.go
##########
@@ -18,14 +18,14 @@ package ms
import (
"context"
pb "github.com/apache/servicecomb-service-center/pkg/registry"
- "github.com/apache/servicecomb-service-center/server/plugin/registry"
)
type DataSource interface {
- RegisterService(ctx context.Context, service *pb.CreateServiceRequest)
(*registry.PluginResponse, error)
- GetService(ctx context.Context, service *pb.GetServiceRequest)
- UpdateService(ctx context.Context, service
*pb.UpdateServicePropsRequest)
- UnregisterService(ctx context.Context, service *pb.DeleteServiceRequest)
+ RegisterService(ctx context.Context, request *pb.CreateServiceRequest)
(*pb.CreateServiceResponse, error)
+ GetServices(ctx context.Context, request *pb.GetServicesRequest)
(*pb.GetServicesResponse, error)
+ GetService(ctx context.Context, request *pb.GetServiceRequest)
(*pb.GetServiceResponse, error)
+ UpdateService(ctx context.Context, request
*pb.UpdateServicePropsRequest)
Review comment:
done, has add response
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
