popozy commented on a change in pull request #698: URL: https://github.com/apache/servicecomb-service-center/pull/698#discussion_r495751211
########## File path: server/rest/controller/v4/microservice_controller.go ########## @@ -113,13 +113,23 @@ func (s *MicroServiceService) Unregister(w http.ResponseWriter, r *http.Request) ServiceId: serviceID, Force: b, } - resp, _ := core.ServiceAPI.Delete(r.Context(), request) + resp, err := core.ServiceAPI.Delete(r.Context(), request) + if err != nil { + log.Errorf(err, "delete service[%s] failed", serviceID) + controller.WriteError(w, scerr.ErrInternal, "delete service failed") + return + } controller.WriteResponse(w, resp.Response, nil) Review comment: I'll abstract the interfaces declared in v4.go in the future pr, considering the workload. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org