liubao68 commented on code in PR #3513:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/3513#discussion_r1046561921
##########
core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerBootListener.java:
##########
@@ -45,8 +49,16 @@
public class ProducerBootListener implements BootListener {
private static final Logger LOGGER =
LoggerFactory.getLogger(ProducerBootListener.class);
+ private static final String pattern = File.separator + "%s" + File.separator
+ "%s.yaml";
+
+ private static final String tmpDir = System.getProperty("java.io.tmpdir") +
File.separator + "microservices";
+
@Override
public void onAfterTransport(BootEvent event) {
+ boolean exportToFile = DynamicPropertyFactory.getInstance()
+ .getBooleanProperty(DefinitionConst.SWAGGER_EXPORT_ENABLED,
false).get();
+ String filePath = DynamicPropertyFactory.getInstance()
+ .getStringProperty(DefinitionConst.SWAGGER_DIRECTORY,
tmpDir).get() + pattern;
Review Comment:
`microservices` sub folder it better created by code, not specified by user.
##########
core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerBootListener.java:
##########
@@ -45,8 +49,16 @@
public class ProducerBootListener implements BootListener {
private static final Logger LOGGER =
LoggerFactory.getLogger(ProducerBootListener.class);
+ private static final String pattern = File.separator + "%s" + File.separator
+ "%s.yaml";
+
+ private static final String tmpDir = System.getProperty("java.io.tmpdir") +
File.separator + "microservices";
+
@Override
public void onAfterTransport(BootEvent event) {
+ boolean exportToFile = DynamicPropertyFactory.getInstance()
+ .getBooleanProperty(DefinitionConst.SWAGGER_EXPORT_ENABLED,
false).get();
+ String filePath = DynamicPropertyFactory.getInstance()
+ .getStringProperty(DefinitionConst.SWAGGER_DIRECTORY,
tmpDir).get() + pattern;
Review Comment:
`microservices` sub folder is better created by code, not specified by user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
