liubao68 commented on code in PR #3513:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/3513#discussion_r1057084166
##########
core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerBootListener.java:
##########
@@ -63,6 +76,9 @@ public void onAfterTransport(BootEvent event) {
Swagger swagger = schemaMeta.getSwagger();
swagger.addScheme(Scheme.forValue(swaggerSchema));
String content = SwaggerUtils.swaggerToString(swagger);
+ if (exportToFile) {
Review Comment:
```
if (exportToFile) {
exportToFile(String.format(filePath, microservice.getServiceName(),
schemaMeta.getSchemaId()), content);
} else {
LOGGER.info("generate swagger for {}/{}/{}, swagger: {}",
microserviceMeta.getAppId(),
microserviceMeta.getMicroserviceName(),
schemaMeta.getSchemaId(),
content);
}
```
is better? Do you think so? By default not print contents in logs, because
users can read swagger in temporary file or in service center.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
