rombert commented on code in PR #44: URL: https://github.com/apache/sling-org-apache-sling-auth-oauth-client/pull/44#discussion_r2959047541
########## src/main/java/org/apache/sling/auth/oauth_client/impl/JcrUserHomeOAuthTokenStore.java: ########## @@ -40,10 +43,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import static org.osgi.service.component.annotations.ConfigurationPolicy.REQUIRE; - -// a config class is intentionally not defined, but a config is required to select an implementation -@Component(configurationPolicy = REQUIRE) +@Component(property = "service.ranking:Integer=0") Review Comment: I think it's problematic to have multiple references around, especially if consumers don't properly bind to the right one. What problem did you encounter with the current pattern of requiring a configuration to activate token stores? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
