nscendoni commented on code in PR #44: URL: https://github.com/apache/sling-org-apache-sling-auth-oauth-client/pull/44#discussion_r2959938084
########## src/main/java/org/apache/sling/auth/oauth_client/impl/JcrUserHomeOAuthTokenStore.java: ########## @@ -40,10 +43,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import static org.osgi.service.component.annotations.ConfigurationPolicy.REQUIRE; - -// a config class is intentionally not defined, but a config is required to select an implementation -@Component(configurationPolicy = REQUIRE) +@Component(property = "service.ranking:Integer=0") Review Comment: OidcAuthenticatonHandler requires LogoutHandler that don't start without a configuration of OAuthTokenStore. We may modify it to have an optional reference to OAuthTokenStore. We need to document that the an OAuthTokenStore must be configured to enable Idp Single Log out. It may sound a bit wired without knowing the internals, but we can do that. I don't have a strong opinion on that. Do you agree with that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
