royteeuwen opened a new pull request, #50: URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/50
**Stack: 1 of 2** — #48 (shallow clone) builds on this. Split out of #48 per review feedback: those were fixes rather than part of the shallow-clone change, and belong lower in the stack. All three are problems that only showed up running the website update against a real checkout, not in the unit tests as they were. **`ensureRepo` reset the wrong branch.** It hard-reset whatever branch happened to be checked out. Since the checkout location is configurable it may be one someone else is using, whose branch would be reset and the release then committed onto it. The published branch is now checked out explicitly first. **Commits recorded the wrong committer.** Only the author was set, so JGit derived the committer from the process user and hostname — `root@<container id>` inside the image. Both are now set. **A false "add it by hand" warning.** An entry that already carried the released version was reported as missing from the downloads page, because the result could not distinguish an absent entry from an up-to-date one. Re-running `finalize` therefore raised a false alarm on every re-run; the two cases are now separate. Also silences JGit's filesystem-timestamp-resolution warning, which it emits when it cannot measure the resolution of the directory holding the checkout. It reads like a failure mid-release and there is nothing to act on. Verified: full build green on its own (176 tests). The committer fix in particular was caught by the real-repository tests added in #40 — the previous mocked version asserted against itself and could not see it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
