royteeuwen commented on PR #50: URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/50#issuecomment-5297308059
Rebased onto master (which now carries the image rename from #41) and pushed two further fixes found while reviewing this branch: - **`ensureRepo` could throw `CheckoutConflictException`.** Switching to the published branch was not preceded by discarding the working tree, so it failed whenever the configured checkout sat on another branch with an uncommitted change to a file whose content differs between the two — exactly the situation the branch handling exists for. The earlier test missed it because it branched at the same commit, making the switch a no-op; the new test commits a divergent change first, and I confirmed it reproduces `CheckoutConflict` without the fix. - **An up-to-date downloads entry could hide a missing sibling.** The outcome was decided on counters summed over all of a release's artifact ids, so for a multi-artifact release (`sling-mock` has `.core`/`.junit4`/`.junit5`) one already-current entry suppressed the warning about one that was absent, and the message named ids as listed that were not. Each artifact id is now classified on its own. Also confirmed to fail without the fix. Plus closing the `Git` returned by the clone, which leaked the repository and its pack handles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
