royteeuwen commented on PR #48: URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/48#issuecomment-5297085404
Thanks @rombert — you were right that this PR mixed things up. Split as follows: - **#50** — the three fixes that were buried in here: `ensureRepo` resetting whatever branch was checked out, the commit recording `root@<container id>` as committer, and the false "add it by hand" warning when the downloads entry was already up to date. Plus the JGit filesystem-warning noise. - **this PR** — only the shallow clone and the test that covers it. Both build independently (176 and 179 tests), so the two are reviewable on their own. On the wider point about the shape of the stack — 1 PR to make the site update work, 1 PR to integrate it into `finalize` — that one I cannot retrofit: #40 contained both and is already merged, so the split would have had to happen before it went in. Noted for next time; the remaining work is decomposed the way you asked. One mechanical snag: I could not set this PR's base to #50's branch, because the merged #47 and #40 pin the original stack and GitHub refuses to unstack it (`Pull requests #47, #40 cannot be removed from this stack`), which also blocks changing the base. So both PRs target `master` and the diff here shows two commits until #50 merges, after which it shows only `281545c`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
