royteeuwen commented on PR #48: URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/48#issuecomment-5297362615
Also fixed the remaining concern from reviewing this branch: `fetch().setDepth(1)` was requested unconditionally, so refreshing a checkout that was *not* shallow silently truncated its history — `git` writes `.git/shallow` and recovering needs `--unshallow`. Since `--site-checkout` can point anywhere, that could quietly damage a release manager's own clone of `sling-site`. The shallow fetch is now only requested when the checkout is already shallow, so: - the container's own checkout (cloned shallow here) stays shallow and does not grow back into a full clone; - a full clone someone points at it keeps its history. Covered both ways: a new test asserts a full checkout stays full after a refresh (confirmed to fail without the guard — *"a full checkout must stay full"*), and the existing shallow tests still assert the shallow checkout stays shallow. The README caveat is relaxed accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
