[
https://issues.apache.org/jira/browse/TAP5-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700982#action_12700982
]
Howard M. Lewis Ship commented on TAP5-658:
-------------------------------------------
PersistentLocale.set() now gets invoked when the request dispatching logic
(mostly inside ComponentEventLinkEncoder) identifies that a locale was
specified inside the request. Setting this value is meaningful later in the
request if any links are rendered, as the locale will be encoded into the URL
by CELE (or its override). This can be in the path itself, as a cookie, or as a
query parameter. So the definition of how PersistentLocale is used shifted a
bit between releases. I would have considered deprecating the interface and
creating a new one with a different name except that PersistentLocale.set() is
the way to programattically select a new persistent locale in both 5.0 and 5.1
and that was, practically speaking, the key bit of API that needed to stay
consistent between releases.
> Optimizations for custom persistent locale implementations
> ----------------------------------------------------------
>
> Key: TAP5-658
> URL: https://issues.apache.org/jira/browse/TAP5-658
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Andy Blower
> Priority: Minor
>
> I was wondering if having a method in LocalizationSetter that allows a Locale
> to be passed would be a good idea. This would remove the conversion to String
> and back again which occurs for every request if you are actually storing a
> locale with a custom persistent locale implementation.
> The other slight annoyance I have with this area of T5 is that
> PersistentLocale.set() being constantly called by the LocalizationSetter for
> each request, this doesn't fit in with the old way that the PersistentLocale
> service was used. I think that only executing persistentLocale.set(locale);
> (line 113) if ENCODE_LOCALE_INTO_PATH is true would be a nice little
> improvement/optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
