[
https://issues.apache.org/jira/browse/TAP5-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700983#action_12700983
]
Howard M. Lewis Ship commented on TAP5-658:
-------------------------------------------
W.R.T. the remainder of this request: if you have rewritten CELE to handle
locales your own way, you probably don't need LocalizationSetter anyway:
outside of some parsing and validation, it invokes ThreadLocale.setLocale() and
maybe PersistentLocale.set(). You code, in your presumed replacement CELE, can
do that directly.
> Optimizations for custom persistent locale implementations
> ----------------------------------------------------------
>
> Key: TAP5-658
> URL: https://issues.apache.org/jira/browse/TAP5-658
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.4
> Reporter: Andy Blower
> Priority: Minor
>
> I was wondering if having a method in LocalizationSetter that allows a Locale
> to be passed would be a good idea. This would remove the conversion to String
> and back again which occurs for every request if you are actually storing a
> locale with a custom persistent locale implementation.
> The other slight annoyance I have with this area of T5 is that
> PersistentLocale.set() being constantly called by the LocalizationSetter for
> each request, this doesn't fit in with the old way that the PersistentLocale
> service was used. I think that only executing persistentLocale.set(locale);
> (line 113) if ENCODE_LOCALE_INTO_PATH is true would be a nice little
> improvement/optimization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
