[
https://issues.apache.org/jira/browse/TAP5-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18072944#comment-18072944
]
Hudson commented on TAP5-2809:
------------------------------
FAILURE: Integrated in Jenkins build Tapestry » tapestry-trunk-freestyle #341
(See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-trunk-freestyle/341/])
TAP5-2809: exlcude netty from mavenLocal, improve project version guards (benw:
rev d9e553a94c9c8b19a7aefce5ae8ca54d3c065e93)
* (edit) settings.gradle
TAP5-2809: run JUnit4 via vintage engine, add explicit testNG task (benw: rev
2b31a26e2b463a7d0072ad8845f4f4df2b24ffc6)
* (edit) buildSrc/src/main/groovy/tapestry.testing-base-convention.gradle
* (edit) buildSrc/src/main/groovy/tapestry.testng-convention.gradle
* (edit) gradle/libs.versions.toml
* (edit) Jenkinsfile
* (edit) buildSrc/src/main/groovy/tapestry.junit4-legacy-convention.gradle
> Improve/Fix Gradle Setup
> ------------------------
>
> Key: TAP5-2809
> URL: https://issues.apache.org/jira/browse/TAP5-2809
> Project: Tapestry 5
> Issue Type: Task
> Affects Versions: 5.9.1
> Reporter: Ben Weidig
> Assignee: Ben Weidig
> Priority: Major
>
> The current Gradle setup has multiple issues:
> * Pre-Java 8 remnants
> * Incomplete upgrade to JUnit 5
> * Incorrect testng.xml
> * Misaligned dependency version between projects
>
> To improve the situation, I suggest:
> * Remove all pre-Java 8 options
> * Create Gradle conventions for
> ** Subproject setup
> ** JUnit 5 (+Spock)
> ** TestNG (and move testng.xml to default locations)
> ** JUnit 4 for legacy reasons
> * Introducing version catalogs for shared dependencies and a consistent
> declaration of module-specific dependencies.
>
> In a second step, more tasks, like Javadoc-related tasks or publishing, could
> be done with conventions or build plugins, to make them easier to use and
> maintain.
> The overall risk is breaking the build and breaking changes for Tapestry
> users if a dependency is no longer exposed.
> However, choosing the right configuration so as not to accidentally export
> dependencies is more critical, and the error messages should clearly state
> why a build is no longer working.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
