[
https://issues.apache.org/jira/browse/TAP5-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18074041#comment-18074041
]
Hudson commented on TAP5-2809:
------------------------------
FAILURE: Integrated in Jenkins build Tapestry » tapestry-trunk-freestyle #343
(See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-trunk-freestyle/343/])
TAP5-2809: run TestNG unit tests via Jupiter, integration tests native, more
cleanup (benw: rev 1f3dd17f2a9c9f28bf165a555d30305e84a07591)
* (edit) Jenkinsfile
* (edit)
tapestry-jpa/src/test/java/org/apache/tapestry5/internal/jpa/JpaTransactionAdvisorImplTest.java
* (delete) buildSrc/src/main/groovy/t5build/Scp.groovy
* (edit) gradle/libs.versions.toml
* (edit) tapestry-hibernate/build.gradle
* (edit) tapestry-jpa/src/test/java/org/apache/tapestry5/jpa/test/JpaTest.java
* (edit) tapestry-cdi/build.gradle
* (edit)
tapestry-kaptcha/src/test/java/org/apache/tapestry5/kaptcha/components/KaptchaUnitTest.java
* (edit) tapestry-upload/build.gradle
* (edit) tapestry-webresources/build.gradle
* (edit) buildSrc/src/main/groovy/tapestry.testing-base-convention.gradle
* (edit) tapestry-ioc/build.gradle
* (delete) buildSrc/src/main/groovy/tapestry.ssh-convention.gradle
* (edit) tapestry-core/src/test/resources/testng.xml
* (edit) buildSrc/src/main/groovy/tapestry.java-convention.gradle
* (edit) build.gradle
* (edit) buildSrc/src/main/groovy/tapestry.junit4-legacy-convention.gradle
* (edit) tapestry-core/build.gradle
* (edit) tapestry-kaptcha/build.gradle
* (edit) tapestry-spring/src/test/resources/testng.xml
* (edit) tapestry-jmx/build.gradle
* (delete) buildSrc/src/main/groovy/t5build/SSshExec.groovy
* (edit) buildSrc/src/main/groovy/tapestry.junit5-convention.gradle
* (edit) tapestry-spring/build.gradle
* (edit) tapestry-beanvalidator/build.gradle
* (edit) tapestry-kaptcha/src/test/resources/testng.xml
* (edit) settings.gradle
* (edit) tapestry-hibernate-core/build.gradle
* (edit) tapestry-hibernate/src/test/resources/testng.xml
* (edit) tapestry-test/build.gradle
* (edit) buildSrc/src/main/groovy/tapestry.junit5-spock-convention.gradle
* (edit) tapestry-upload/src/test/resources/testng.xml
* (edit) quickstart/build.gradle
* (delete) buildSrc/src/main/groovy/t5build/TapestryBuildLogic.groovy
* (edit) tapestry-jpa/build.gradle
* (add) buildSrc/README.md
* (edit) buildSrc/src/main/groovy/tapestry.testng-convention.gradle
* (delete) buildSrc/src/main/groovy/t5build/SshTask.groovy
* (edit) tapestry-http/build.gradle
* (edit) Jenkinsfile.integration-variants
* (add) tapestry-http/src/test/resources/testng.xml
> Improve/Fix Gradle Setup
> ------------------------
>
> Key: TAP5-2809
> URL: https://issues.apache.org/jira/browse/TAP5-2809
> Project: Tapestry 5
> Issue Type: Task
> Affects Versions: 5.9.1
> Reporter: Ben Weidig
> Assignee: Ben Weidig
> Priority: Major
>
> The current Gradle setup has multiple issues:
> * Pre-Java 8 remnants
> * Incomplete upgrade to JUnit 5
> * Incorrect testng.xml
> * Misaligned dependency version between projects
>
> To improve the situation, I suggest:
> * Remove all pre-Java 8 options
> * Create Gradle conventions for
> ** Subproject setup
> ** JUnit 5 (+Spock)
> ** TestNG (and move testng.xml to default locations)
> ** JUnit 4 for legacy reasons
> * Introducing version catalogs for shared dependencies and a consistent
> declaration of module-specific dependencies.
>
> In a second step, more tasks, like Javadoc-related tasks or publishing, could
> be done with conventions or build plugins, to make them easier to use and
> maintain.
> The overall risk is breaking the build and breaking changes for Tapestry
> users if a dependency is no longer exposed.
> However, choosing the right configuration so as not to accidentally export
> dependencies is more critical, and the error messages should clearly state
> why a build is no longer working.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
