[
https://issues.apache.org/jira/browse/TAP5-2809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18074533#comment-18074533
]
Hudson commented on TAP5-2809:
------------------------------
SUCCESS: Integrated in Jenkins build Tapestry » tapestry-java-17-freestyle #208
(See
[https://ci-builds.apache.org/job/Tapestry/job/tapestry-java-17-freestyle/208/])
TAP5-2809: NpmTask with Docker support, don't emit TypeScript types into
es-modules (benw: rev cd3518fea9fe6a2ef02e410af9a78ab11ca68384)
* (edit) tapestry-core/build.gradle
* (edit) tapestry-core/src/main/typescript/tsconfig.json
* (edit) tapestry-core/src/main/typescript/package.json
* (add) buildSrc/src/main/groovy/t5build/NpmTask.groovy
TAP5-2809: add missing license info to GenerateCheksums.groovy (benw: rev
89bea1afa40ccc73289c2d694dfd4482d4fa6d66)
* (edit) buildSrc/src/main/groovy/t5build/GenerateChecksums.groovy
TAP5-2809/2819: Integration testing streamlined (benw: rev
8a640f34a5b42772a3db3cad2b28d3c303f2694f)
* (edit) tapestry-core/build.gradle
* (edit) Jenkinsfile.integration-variants
* (edit) buildSrc/src/main/groovy/tapestry.testing-base-convention.gradle
TAP5-2809: NpmTask use /tmp/.npm as cache (benw: rev
91d4f899a582a4db46772265ac45fc71038829c3)
* (edit) buildSrc/src/main/groovy/t5build/NpmTask.groovy
> Improve/Fix Gradle Setup
> ------------------------
>
> Key: TAP5-2809
> URL: https://issues.apache.org/jira/browse/TAP5-2809
> Project: Tapestry 5
> Issue Type: Task
> Affects Versions: 5.9.1
> Reporter: Ben Weidig
> Assignee: Ben Weidig
> Priority: Major
>
> The current Gradle setup has multiple issues:
> * Pre-Java 8 remnants
> * Incomplete upgrade to JUnit 5
> * Incorrect testng.xml
> * Misaligned dependency version between projects
>
> To improve the situation, I suggest:
> * Remove all pre-Java 8 options
> * Create Gradle conventions for
> ** Subproject setup
> ** JUnit 5 (+Spock)
> ** TestNG (and move testng.xml to default locations)
> ** JUnit 4 for legacy reasons
> * Introducing version catalogs for shared dependencies and a consistent
> declaration of module-specific dependencies.
>
> In a second step, more tasks, like Javadoc-related tasks or publishing, could
> be done with conventions or build plugins, to make them easier to use and
> maintain.
> The overall risk is breaking the build and breaking changes for Tapestry
> users if a dependency is no longer exposed.
> However, choosing the right configuration so as not to accidentally export
> dependencies is more critical, and the error messages should clearly state
> why a build is no longer working.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
