The GitHub Actions job "Required Checks" on texera.git/chore/monaco-lsp-v10 has 
failed.
Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).

Head commit for run:
e8e67b56c7ca3a8acf3b0143b04293357f1251ca / Xinyuan Lin <[email protected]>
chore(frontend): tidy code-debugger imports and jsdom polyfill comments

Sweep over the files this PR touched looking for cleanups that didn't fit
into the focused commits:

* `code-debugger.component.ts`: drop the two static
  `import "@codingame/monaco-vscode-{python,java}-default-extension"` side-
  effect imports. They duplicate the dynamic imports inside
  `CodeEditorComponent.ensureVscodeApiStarted()` (which already loads them
  after `MonacoVscodeApiWrapper.start()` and awaits each `whenReady()`),
  and are documented elsewhere in this file as tree-shaken by the Angular
  build pipeline anyway, so the static form is dead either way.

* `jsdom-svg-polyfill.ts`:
  * The top-level docblock was talking about SVG geometry stubs, but the
    very next code in the file was the Node ESM `.css` loader hook —
    confusing for anyone landing in the file. Replaced the top docblock
    with a one-paragraph file overview and moved the SVG paragraph to
    where the SVG stubs actually are.
  * Merged the two `Document.prototype` lookups (`docProtoForCss` for
    `adoptedStyleSheets`, `docProto` for `queryCommandSupported`) into a
    single `docProto` block. Same constant, same prototype, two patches.
  * Tightened the `requestIdleCallback` block comment to a single
    leading-line comment to match the style of the SVG / loader-hook
    sections.

No behaviour change. yarn build:ci EXIT 0; check_binary_deps.py OK; yarn
test stays at 63 / 269.

Report URL: https://github.com/apache/texera/actions/runs/25597129508

With regards,
GitHub Actions via GitBox

Reply via email to