The GitHub Actions job "Required Checks" on texera.git/chore/monaco-lsp-v10 has 
failed.
Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).

Head commit for run:
33eea83c83a4f34a15ff1b790714e384604253d2 / Xinyuan Lin <[email protected]>
chore(frontend): address Copilot follow-up + drop redundant Selection 
construction

Two new Copilot review comments on #4997, plus a small drive-by:

* `jsdom-svg-polyfill.ts`: vitest re-evaluates `setupFiles` once per spec
  file, so the unconditional `module.register(...)` was chaining a fresh
  `.css` ESM hook for every spec — slower (and noisier) module resolution
  across the run. Guard the registration with a `Symbol.for(...)`-keyed
  flag on `globalThis` so the hook installs exactly once per process.

* `code-editor.component.ts` (Copilot — code-debugger static imports):
  already addressed in e8e67b56c7; reply on the thread.

* `code-editor.component.ts` drive-by: `acceptCurrentAnnotation` was
  building a `monaco.Selection` from `currentRange` only to pass it to
  `insertTypeAnnotations`, which in turn only read `endLineNumber` /
  `endColumn` — fields `monaco.Range` already exposes. Dropped the
  `Selection` construction; `insertTypeAnnotations` now takes the
  `Range` directly. Switched the offset fallback to `??` so a real `0`
  offset isn't masked.

yarn build:ci EXIT 0; check_binary_deps.py OK: 113; yarn test 63 / 269.

Report URL: https://github.com/apache/texera/actions/runs/25599234185

With regards,
GitHub Actions via GitBox

Reply via email to