The GitHub Actions job "Required Checks" on texera.git/main has failed. Run started by GitHub user github-merge-queue[bot] (triggered by github-merge-queue[bot]).
Head commit for run: 71faf440de7936d07451d214dbd5777e6906b949 / Kary Zheng <[email protected]> feat(visualization): retarget attributeTypeRules at the properties they name (#7249) ### What changes were proposed in this PR? Four `attributeTypeRules` name keys that match no property, so the property editor's `findAttributeType` returns `undefined` and `checkConstraint` returns without checking anything. `LineConfig` used the Scala field names rather than the `@JsonProperty` names, and `ScatterMatrixChartOpDesc` named `value` where the property is `Selected Attributes`; both are retargeted at the property they meant. `Scatter3dChartOpDesc` and `FunnelPlotOpDesc` constrained a `title` that neither operator declares, and did so with the bare string `"string"` rather than an object, so even under a correct key `constraint.enum` / `const` / `allOf` would all be undefined and the check would still no-op; those two rules are removed rather than invented anew. ### Why are the changes needed? A line chart's x and y axes accept string columns today despite declaring `["integer", "long", "double"]`, and the same holds for the scatter matrix's dimensions. `BandConfig` extends `LineConfig` and inherited the same dead rule. Nothing reports a key that names no property, so the rules read as enforced while enforcing nothing. ### Any related issues, documentation, discussions? Closes #7210 ### How was this PR tested? `WorkflowOperator/compile`, `WorkflowOperator/scalafmtCheckAll`, and the four operators' existing descriptor specs (24 tests, all passing). The new `AttributeTypeRuleTargetSpec` guards the class of mistake repo-wide rather than just the four sites fixed here: it walks every registered operator's generated schema and fails if an `attributeTypeRules` key names no declared property, or if a rule is not stated as an object. ### Does this PR introduce any user-facing change? Yes. Selecting a non-numeric column for a line chart's axes or the scatter matrix's Selected Attributes now shows the type warning the rule always intended. Nothing changes for a numeric column, and removing the two `title` rules changes nothing at all, since they never applied. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5) --------- Co-authored-by: Claude Opus 5 (1M context) <[email protected]> Co-authored-by: Xuan Gu <[email protected]> Report URL: https://github.com/apache/texera/actions/runs/31645076855 With regards, GitHub Actions via GitBox
