The GitHub Actions job "Required Checks" on texera.git/main has failed. Run started by GitHub user github-merge-queue[bot] (triggered by github-merge-queue[bot]).
Head commit for run: dd7d813e92e9194e96d74b6926e48065462901ca / Xinyuan Lin <[email protected]> chore(amber): remove the deprecated ExpansionGreedyScheduleGenerator (#7446) ### What changes were proposed in this PR? Acts on the removal notice `ExpansionGreedyScheduleGenerator` has carried since #3542. Pure deletion of the class and its spec, no behaviour change: **−832 lines**. #3144 ("Refactoring of Schedule Generation", 2024-12-14) made `CostBasedScheduleGenerator` the only generator the engine constructs. #3542 (2025-07-09) then annotated the greedy one with the notice it still carries today: > This greedy schedule generator will be removed in the future. Use `CostBasedScheduleGenerator` instead. ``` WorkflowScheduler.scala:46 -> new CostBasedScheduleGenerator(...) (live, untouched) ExpansionGreedyScheduleGenerator (unreachable since #3144) ``` The dead class is already costing maintenance: #7473 had to edit a call site inside it purely to keep it compiling after `createPortBaseURI` gained a `warehouse` parameter. No configuration can bring it back: the `schedule-generator` block in `application.conf` holds only CostBased tuning parameters (`max-concurrent-regions`, `use-global-search`, `use-top-down-search`, `search-timeout`, read at `ApplicationConfig.scala:87-90`), with no generator-selection key. > Reviewer note: the abstract base `ScheduleGenerator` is **not** touched — `CostBasedScheduleGenerator` extends it and is unaffected. Only the greedy subclass and its spec are removed. ### Any related issues, documentation, discussions? Closes #7444 ### How was this PR tested? Existing tests only — this PR adds none, since it removes code and the spec that covered it. Locally, from the repo root with Java 17: - `sbt "WorkflowExecutionService/Test/compile"` — success (main and test sources). Verification that nothing references the removed class, re-runnable by a reviewer: ``` git grep -n ExpansionGreedy # only the two deleted files git grep -in greedy -- '*.conf' '*.yml' '*.yaml' '*.json' '*.properties' # no generator-selection key ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5) Report URL: https://github.com/apache/texera/actions/runs/31665399757 With regards, GitHub Actions via GitBox
