The GitHub Actions job "Required Checks" on texera.git/main has failed. Run started by GitHub user github-merge-queue[bot] (triggered by github-merge-queue[bot]).
Head commit for run: facdc2186d03f7efa87f02431e8a3b749830f94c / Xinyuan Lin <[email protected]> refactor(frontend): remove dead AgentChatComponent members (#8697) ### What changes were proposed in this PR? Deletes six dead members of `AgentChatComponent`. **+3/−91 lines.** There is no behaviour change. - `getToolResult`, `getToolOperatorAccess` and `hasOperatorAccess`. The step-detail modal's template calls `ReActStepDetailModalComponent`'s own copies of these, not the chat component's. - `closeDetailsModal`, which is no longer bound anywhere. The modal closes through the `[(visible)]` binding. - The private `scrollToMessage`, which lost its only caller in #8613. - The `messageInput` `@ViewChild`, which was never read, and its `#messageInput` template ref. The spec loses the four cases that only exercised these members, plus the `scrollIntoView` stub that existed for `scrollToMessage`. ### History | | | | --- | --- | | **Introduced by** | #4020 (2025-11-25), "feat: introduce the LLM-based workflow copilot": `getToolResult`, `closeDetailsModal`, `messageInput`. #4495 (2026-04-27) added `getToolOperatorAccess`, `hasOperatorAccess` and `scrollToMessage` | | **Usage removed by** | #4495 (2026-04-27), "feat(agent-service): add agent-service that manages LLM agents". It moved step details into `ReActStepDetailModalComponent` (with its own copies) and deleted the chat template's calls. The three members it added, and `messageInput`, were **never used**. `scrollToMessage` was never reachable, and #8613 removed its only static caller | It has been dead for five months. > Reviewer note: open draft #5928 (bobbai00) also drops the operator-access members as part of a larger refactor. If it lands second, the conflict is a trivial delete/delete. #8613 should have taken `scrollToMessage` with its caller; this PR finishes that. ### Any related issues, documentation, discussions? Closes #8696 ### How was this PR tested? No new tests. The kept cases, including the `[(visible)]` two-way-binding case, cover what remains. >From `frontend/`: - `npx ng test --watch=false --include='**/agent-chat.component.spec.ts' --include='**/agent-panel.component.spec.ts'`: 2 files, 103 tests, all pass. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n "closeDetailsModal\|scrollToMessage\|messageInput" -- frontend # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Report URL: https://github.com/apache/texera/actions/runs/36355064456 With regards, GitHub Actions via GitBox
