The GitHub Actions job "Required Checks" on texera.git/main has failed. Run started by GitHub user github-merge-queue[bot] (triggered by github-merge-queue[bot]).
Head commit for run: 98b875f812d7c5c9a69908d14df50c282c123550 / Xinyuan Lin <[email protected]> refactor(frontend): remove dead breakpoint popup positioning (#9113) ### What changes were proposed in this PR? Removes `BreakpointConditionInputComponent.left()` and `top()`, two positioning methods that nothing in production calls. **−66 lines.** There is no behaviour change. The popup is positioned by `ngOnChanges`, which computes `topPosition` and `leftPosition` for the template's `[ngStyle]="{ top: topPosition, left: leftPosition }"` binding. The template never calls `left()` or `top()`. The component's one host, `code-debugger`, binds only its inputs and output, and the two parent `ViewChild` fields that reference the component are never read. Every import is still used. The spec loses the five cases that only exercised the two methods. Its coverage of the surviving positioning (`ngOnChanges`, `topPosition`, `leftPosition`) stays. ### History | | | | --- | --- | | **Introduced by** | #2953 (2024-10-25), "Add Udon breakpoint UI - breakpoint-related operations", in the same commit as the `[ngStyle]` positioning that is actually used | | **Usage removed by** | **never used**. Only spec cases (#7304, #7988) ever called them | They have been unused for the two years since they were added. ### Any related issues, documentation, discussions? Closes #9110 ### How was this PR tested? No new tests. The surviving positioning keeps its cases. >From `frontend/`: - `npx ng test --watch=false --include='**/breakpoint-condition-input.component.spec.ts' --include='**/code-debugger.component.spec.ts' --include='**/code-editor.component.spec.ts'`: 3 files, 126 tests, all pass. The last two specs cover the component's host and the code editor that declares it. - `npx tsc --noEmit -p src/tsconfig.app.json` and `-p src/tsconfig.spec.json`: clean. - `yarn format:ci`: clean. - `npx ng build`: success. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Report URL: https://github.com/apache/texera/actions/runs/40215934357 With regards, GitHub Actions via GitBox
