xiazcy commented on code in PR #3090:
URL: https://github.com/apache/tinkerpop/pull/3090#discussion_r2029531855
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/translator/JavascriptTranslator.java:
##########
@@ -144,6 +145,11 @@ protected String getSyntax(final Date o) {
return "new Date(" + o.getTime() + ")";
}
+ @Override
+ protected String getSyntax(final OffsetDateTime o) {
+ return "new Date(" + o.toInstant().toEpochMilli() + ")";
Review Comment:
Not quite, new Date() construction will create a date with local time offset
regardless. The JS Date type is...messy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
