andreachild commented on code in PR #3090:
URL: https://github.com/apache/tinkerpop/pull/3090#discussion_r2031816431
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/AsDateStep.java:
##########
@@ -20,46 +20,44 @@
import org.apache.tinkerpop.gremlin.process.traversal.Traversal;
import org.apache.tinkerpop.gremlin.process.traversal.Traverser;
-import org.apache.tinkerpop.gremlin.process.traversal.step.TraversalParent;
-import
org.apache.tinkerpop.gremlin.process.traversal.step.sideEffect.InjectStep;
import
org.apache.tinkerpop.gremlin.process.traversal.traverser.TraverserRequirement;
-import org.apache.tinkerpop.gremlin.process.traversal.util.TraversalUtil;
import org.apache.tinkerpop.gremlin.structure.util.StringFactory;
import org.apache.tinkerpop.gremlin.util.DatetimeHelper;
import java.math.BigInteger;
+import java.time.Instant;
+import java.time.OffsetDateTime;
+import java.time.ZoneOffset;
import java.time.format.DateTimeParseException;
import java.util.Collections;
-import java.util.Date;
-import java.util.List;
import java.util.Set;
/**
* Reference implementation for date parsing step.
*
* @author Valentyn Kahamlyk
*/
-public final class AsDateStep<S> extends ScalarMapStep<S, Date> {
+public final class AsDateStep<S> extends ScalarMapStep<S, OffsetDateTime> {
public AsDateStep(final Traversal.Admin traversal) {
super(traversal);
}
@Override
- protected Date map(final Traverser.Admin<S> traverser) {
+ protected OffsetDateTime map(final Traverser.Admin<S> traverser) {
final Object object = traverser.get();
if (object == null)
- throw new IllegalArgumentException("Can't parse null as Date.");
- if (object instanceof Date)
- return (Date) object;
+ throw new IllegalArgumentException("Can't parse null as
OffsetDateTime.");
+ if (object instanceof OffsetDateTime)
+ return (OffsetDateTime) object;
if (object instanceof Byte || object instanceof Short || object
instanceof Integer || object instanceof Long)
// numbers handled as milliseconds since January 1, 1970, 00:00:00
GMT.
Review Comment:
Comment should be updated to `UTC` instead of `GMT` which are slightly
different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
