Cole-Greer commented on code in PR #3079:
URL: https://github.com/apache/tinkerpop/pull/3079#discussion_r2031664247
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java:
##########
@@ -526,20 +537,20 @@ private Connection getAvailableConnection() {
private void awaitAvailableConnection(long timeout, TimeUnit unit) throws
InterruptedException {
Review Comment:
Nit: I'm a bit worried of the potential for future mistakes now that the
caller is responsible for obtaining `waitLock` before calling this method. A
javadoc comment here, and on `waitForConnection()` might be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
