andreachild commented on code in PR #3079:
URL: https://github.com/apache/tinkerpop/pull/3079#discussion_r2036207546
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java:
##########
@@ -526,20 +537,20 @@ private Connection getAvailableConnection() {
private void awaitAvailableConnection(long timeout, TimeUnit unit) throws
InterruptedException {
Review Comment:
Technically calling this method on its own does not mandate acquiring the
lock. The issue was the combination of calling `getAvailableConnection` and
then subsequently `waitForConnection` without the lock. I have added a comment
inside of the `borrowConnection` to clarify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
