kenhuuu commented on code in PR #3315:
URL: https://github.com/apache/tinkerpop/pull/3315#discussion_r2933461324
##########
gremlin-dotnet/src/Gremlin.Net/Driver/Remote/DriverRemoteConnection.cs:
##########
@@ -44,22 +44,20 @@ public class DriverRemoteConnection : IRemoteConnection,
IDisposable
private readonly ILogger<DriverRemoteConnection> _logger;
/// <summary>
- /// Filter on these keys provided to OptionsStrategy and apply them to
the request. Note that
- /// "scriptEvaluationTimeout" was deprecated in 3.3.9 but still
supported in server implementations and will
- /// be removed in later versions.
+ /// Filter on these keys provided to OptionsStrategy and apply
them to the request.
/// </summary>
private readonly List<string> _allowedKeys = new()
Review Comment:
Is this actually needed? The server just filters out options that don't
apply and it allows for custom requests from providers. Plus there is an
asymmetry now since you are allowed to add whatever field you want to
RequestMessage if you use the Client directly but DRC won't let you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
