kenhuuu commented on code in PR #3315:
URL: https://github.com/apache/tinkerpop/pull/3315#discussion_r2933605510
##########
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphBinary4/GraphBinaryMessageSerializer.cs:
##########
@@ -24,39 +24,35 @@
using System;
using System.Collections.Generic;
using System.IO;
-using System.Text;
using System.Threading;
using System.Threading.Tasks;
using Gremlin.Net.Driver;
using Gremlin.Net.Driver.Messages;
-namespace Gremlin.Net.Structure.IO.GraphBinary
+namespace Gremlin.Net.Structure.IO.GraphBinary4
{
/// <summary>
- /// Serializes data to and from Gremlin Server in GraphBinary format.
+ /// Serializes data to and from Gremlin Server in GraphBinary 4.0
format.
/// </summary>
public class GraphBinaryMessageSerializer : IMessageSerializer
{
- private const string MimeType =
SerializationTokens.GraphBinary1MimeType;
- private static readonly byte[] Header =
Encoding.UTF8.GetBytes(MimeType);
-
private readonly GraphBinaryReader _reader;
private readonly GraphBinaryWriter _writer;
private readonly RequestMessageSerializer _requestSerializer = new
RequestMessageSerializer();
private readonly ResponseMessageSerializer _responseSerializer = new
ResponseMessageSerializer();
/// <summary>
- /// Initializes a new instance of the <see
cref="GraphBinaryMessageSerializer" /> class.
+ /// Initializes a new instance of the <see
cref="GraphBinaryMessageSerializer" /> class.
/// </summary>
/// <param name="registry">The <see cref="TypeSerializerRegistry"/> to
use for serialization.</param>
public GraphBinaryMessageSerializer(TypeSerializerRegistry? registry =
null)
Review Comment:
Consider updating this as there will no longer be custom
TypeSerializerRegistries so it could just be hardcoded to the internal one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
