kevinthesun commented on a change in pull request #4312: [TOPI][Relay][OP]
Dynamic NMS and strided_slice
URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r345399617
##########
File path: topi/python/topi/vision/nms.py
##########
@@ -289,8 +339,136 @@ def hybrid_nms(data, sorted_index, valid_count,
return output, box_indices
+@hybrid.script
+def hybrid_dynamic_nms(data, sorted_index, max_output_size, score_threshold,
Review comment:
I think we can merge this with existing nms routing. Also we need
valid_count to reduce the number of iteration to prevent nms to be the
performance bottleneck. For tensorflow nms, since we want the original index of
all boxes, we might want to get a mapping from altered box indices to original
box indices, in get_valid_counts function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
