kevinthesun commented on a change in pull request #4312: [TOPI][Relay][OP] Dynamic NMS and strided_slice URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r345404746
########## File path: include/tvm/relay/attrs/vision.h ########## @@ -96,6 +96,7 @@ struct GetValidCountsAttrs : public tvm::AttrsNode<GetValidCountsAttrs> { /*! \brief Attributes used in non_maximum_suppression operator */ struct NonMaximumSuppressionAttrs : public tvm::AttrsNode<NonMaximumSuppressionAttrs> { int max_output_size; + double score_threshold; Review comment: If we change dynamic nms implementation, we might not need this attribute ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services