comaniac commented on a change in pull request #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#discussion_r384021494
########## File path: src/relay/pass/annotate_target.cc ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file src/relay/pass/annotate_target.cc + * \brief Wraps a call with compiler_begin and compiler_end to indicate that + * the op of this call node will use external compiler. + */ + +#include <tvm/relay/attrs/annotation.h> +#include <tvm/relay/expr_functor.h> +#include <tvm/relay/op_attr_types.h> +#include <tvm/relay/transform.h> + +namespace tvm { +namespace relay { +namespace annotate_target { + +// A helper class to insert annotation boundaries for a program region that will +// be handled by a specific compiler. +class AnnotateTargetWrapper : public ExprMutator { + public: + explicit AnnotateTargetWrapper(const std::string& target) : target_(target) {} + + Expr VisitExpr_(const CallNode* cn) { + // TODO(@zhiics, @comaniac) Hanlde composite functions. + auto new_e = ExprMutator::VisitExpr_(cn); + + Call call = Downcast<Call>(new_e); + static auto fannotate = Op::GetAttr<FTVMAnnotateTarget>("target." + target_); + Op op = Downcast<Op>(call->op); + CHECK(op.defined()); + + if (fannotate.count(op)) { + bool external = fannotate[op](call->attrs, call->args); + if (external) { + tvm::Array<tvm::relay::Expr> compiler_begins; + for (const auto& it : call->args) { + const auto* begin_op = + runtime::Registry::Get("relay.op.annotation._make.compiler_begin"); + CHECK(begin_op); + Expr begin = (*begin_op)(it, target_); + compiler_begins.push_back(begin); + } + Expr update_call = CallNode::make(call->op, compiler_begins, call->attrs); + const auto* end_op = + runtime::Registry::Get("relay.op.annotation._make.compiler_end"); + CHECK(end_op); + Expr end = (*end_op)(update_call, target_); + return end; + } + } else { + LOG(WARNING) << op->name << " in " << target_ << " is not registered"; Review comment: I personally think this is valuable warning because developers may forget to add some ops to their annotators. In this case, they may spend lots of time on analyzing performance regression on their accelerator, but the op was executed on CPU. However, we can discuss how to present this warning to end-users. cc @zhiics ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services