comaniac commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-590980676 > I've mostly got a few questions about the direction of the PR. The thing that concerns me is the lack of support for composite operators. I know this is mentioned on a to-do, but registering the 'is supported' logic as an operator attribute is not something we can do with composite functions in the current implementation. Do you have a proposal on how you're going to support composite functions? Since we are still discussing the naming and format of the pass sequence for annotation, this PR does not consider composite functions yet. The follow-up PR will update the annotation pass to annotate not only ops but also functions (with the composite attribute).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
