notoraptor commented on issue #4938: [topi][relay] add operation tan to TVM URL: https://github.com/apache/incubator-tvm/pull/4938#issuecomment-592175539 @kevinthesun Hi ! Thanks! In order to fix failed test (precision error), I am trying to update the `tan` implementation in llvm target (by replacing `sin/cos` with a direct call to llvm's `tan` functions). But it currently generate other issues, so I am working on it. I can rebase now, but I guess test will fail again.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
