zhiics commented on a change in pull request #4951: Conditions updated to cover better user scenarios URL: https://github.com/apache/incubator-tvm/pull/4951#discussion_r386208620
########## File path: tests/python/relay/test_pass_alpha_equal.py ########## @@ -28,6 +28,15 @@ def alpha_equal(x, y): """ return analysis.alpha_equal(x, y) and analysis.structural_hash(x) == analysis.structural_hash(y) +def alpha_equal_commutative(x, y): + """ + Check for commutative property of equality + """ + xy = analysis.alpha_equal(x, y) + yx = analysis.alpha_equal(y, x) + assert xy == yx + return analysis.alpha_equal(x, y) Review comment: `return xy` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services