pasqoc commented on a change in pull request #4986: [VTA][Chisel,de10nano] 
Chisel fixes and de10nano support
URL: https://github.com/apache/incubator-tvm/pull/4986#discussion_r388023813
 
 

 ##########
 File path: vta/hardware/chisel/Makefile
 ##########
 @@ -109,7 +133,7 @@ else
   lib_path = $(vta_dir)/$(BUILD_NAME)/$(VTA_LIBNAME).so
 endif
 
-default: lint lib
 
 Review comment:
   As I explained in the commit message, currently lint messes up indentation 
and requires manual fixes. 
   It would be better in my opinion to perform lint manually after large code 
changes only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to