masahi commented on code in PR #15995:
URL: https://github.com/apache/tvm/pull/15995#discussion_r1374967973
##########
cmake/modules/CUDA.cmake:
##########
@@ -64,6 +64,7 @@ if(USE_CUDA)
message(STATUS "Build with Thrust support")
cmake_minimum_required(VERSION 3.13) # to compile CUDA code
enable_language(CUDA)
+ set(CMAKE_CUDA_ARCHITECTURES "80;75")
Review Comment:
The is due to an odd behavior of cmake that I don't understand. If I remove
this and set `USE_THRUST`, I get
```
CMake Error in CMakeLists.txt:
CUDA_ARCHITECTURES is empty for target "tvm_runtime_objs".
```
. Previously I didn't encounter this problem when I was using `USE_THRUST`
(a couple of years ago).
This doesn't apply to `vllm.cmake` for some reason. But there, if I don't
have `set(CMAKE_CUDA_ARCHITECTURES "80;75")`, I get
```
error : Feature 'f16 arithemetic and compare instructions' requires
.target sm_53 or higher
```
during build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]