cbalint13 commented on code in PR #15995:
URL: https://github.com/apache/tvm/pull/15995#discussion_r1375052987
##########
cmake/modules/CUDA.cmake:
##########
@@ -64,6 +64,7 @@ if(USE_CUDA)
message(STATUS "Build with Thrust support")
cmake_minimum_required(VERSION 3.13) # to compile CUDA code
enable_language(CUDA)
+ set(CMAKE_CUDA_ARCHITECTURES "80;75")
Review Comment:
@masahi
CMAKE_CUDA_ARCHITECTURES is designed to be eprovided by user at cmake config
time.
* There are also values like 'auto', 'all' see
[CUDA_ARCHITECTURES](https://cmake.org/cmake/help/latest/prop_tgt/CUDA_ARCHITECTURES.html)
* Better throw a warning like: 'Using 'all' for CUDAARCHS, use
CMAKE_CUDA_ARCHITECTURES to override'.
* Also it is initialized by env var
[CUDAARCHS](https://cmake.org/cmake/help/latest/variable/CMAKE_CUDA_ARCHITECTURES.html)
and picked up from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
